Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sphinx documentation formatting fixes #66

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

meliache
Copy link
Collaborator

@meliache meliache commented Feb 9, 2021

I worked on removing some of the sphinx warnings that I mention in issue #64. Most importantly, the example for get_input_file_names_from_dict() by @welschma was not rendered as a code block.

I haven't yet managed to remove all warnings, one type of warning still remains:

/home/michael/basf2/externals/v01-09-01/Linux_x86_64/common/lib/python3.6/site-packages/b2luigi/basf2_helper/data.py:docstring of b2luigi.basf2_helper.data.CdstDataTask.output:13: WARNING: undefined label: task.output (if the link has no caption the label must precede a section header)

And the same for some other tasks with the output() method that are automatically included. But I couldn't come up with a quick fix and the docs for the CdstDataTask etc. look nice despite the warning, so I think I should just merge what I have so far and get on with more important issues.

Old Fixed
grafik grafik

The code formatting for the example in the docs for
``get_input_file_names_from_dict()`` was broken, so I fixed that, by adding an
additional code-block environment.

Also I changed one other example for consistency, so that the text "Example" is
now the key/label of an RST definition list.
Otherwise, sphinx formats everything right but gives a warning. Also, my edtior
added a newline at the end of basf2_helper.rst.
@meliache meliache merged commit 8d6fd0f into main Feb 9, 2021
@meliache meliache deleted the feature/documentation-formatting-fixes branch February 9, 2021 16:34
@meliache meliache added the enhancement New feature or request label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant